Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add workflow for spark and changelog #998

Merged
merged 1 commit into from
Mar 19, 2024

Conversation

VersusFacit
Copy link
Contributor

resolves 38 of epic

This PR adds a workflow file for bigquery testing. It is based on dbt-labs/dbt-redshift#732. I assume there will be some quirks to work out. Also, we'll need to add aws secrets.

@VersusFacit VersusFacit self-assigned this Mar 18, 2024
@cla-bot cla-bot bot added the cla:yes label Mar 18, 2024
@VersusFacit VersusFacit requested review from emmyoop and aranke March 18, 2024 10:38
Copy link
Member

@emmyoop emmyoop left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All the same questions/changes in dbt-labs/dbt-redshift#732

@@ -0,0 +1,6 @@
kind: Features
body: ': Add new workflow for internal patch releases'
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If adapters wants these changelogs

Suggested change
body: ': Add new workflow for internal patch releases'
body: 'Add new workflow for internal patch releases'

Copy link
Member

@emmyoop emmyoop left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approving as is for now with the understanding that more PRs will follow on after testing since none of this can be tested before the workflow gets merged. Since this is a workflow that will be manually submitted there is little risk in this approach.

@VersusFacit VersusFacit merged commit 748c7f6 into main Mar 19, 2024
31 of 33 checks passed
@VersusFacit VersusFacit deleted the add_release_internal_workflow branch March 19, 2024 01:15
@VersusFacit
Copy link
Contributor Author

Added this to test tonight -- second PR inc.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants